i810 modesetting dist fixes

Eric Anholt eric at anholt.net
Mon Jan 1 13:07:56 PST 2007


On Mon, 2007-01-01 at 11:48 -0800, Keith Packard wrote:
> On Mon, 2007-01-01 at 15:26 +0000, Ross Burton wrote:
> > Hi,
> > 
> > I'm attempting to build packages of the modesetting/xrandr 1.2 code from
> > git to test it on my ThinkPad X60, and hit a problem with the
> > modesetting branch of the i810 driver.
> > 
> > Attached is a patch that:

> > 2) includes i830.h in i830_xf86Crtc.c so that it builds against older X
> > servers (currently I don't have xserver 7.2 built)
> 
> This "shouldn't" be necessary; the eventual goal is to make
> i830_xf86Crtc.c part of xfree86/common. Can you explain what is broken
> here?

i830.h has the M_T_PREFERRED and friends compat defines for people with
old released X servers.  I've been including it in our other files of
generic code so we'll be sure to remove it when we move it to the
server, unlike if we copied the #ifndef block into the file.

-- 
Eric Anholt                             anholt at FreeBSD.org
eric at anholt.net                         eric.anholt at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg/attachments/20070101/343ab355/attachment.pgp>


More information about the xorg mailing list