Getting xserver patches reviewed

Egbert Eich eich at suse.de
Mon Nov 26 21:13:03 PST 2007


Daniel Stone writes:
 > On Mon, Nov 26, 2007 at 10:27:42AM -0800, Alan Coopersmith wrote:
 > > Bernardo Innocenti wrote:
 > > > There are a bunch of older xserver and libX11 patches
 > > > that I submitted to the xorg@ list, which went mostly
 > > > ignored for a very long time.
 > > 
 > > When developers have time to review patches, they usually look
 > > in bugzilla, not the mailing list archives, since it's much
 > > easier to search there and find which patches have been applied
 > > (and thus the bugs closed) and which still need to be reviewed.
 > > Make sure to include the keyword "patch", so it shows up on the
 > > list of outstanding patches at:
 > > 
 > > https://bugs.freedesktop.org/buglist.cgi?keywords=patch&product=xorg&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED
 > 
 > Actually, to be honest, I usually only find myself with time[0] on
 > planes, trains, and, er, buses, which rules Bugzilla out.  I do a search
 > for [PATCH] through xorg@ and review all my flagged mail, and I try to
 > flag interesting patches.
 > 

I'm in a similar situation. This however doesn't invalidate the notion
to aslo submit a patch to bugzilla is a good idea.
Bugzilla allows to go back and find the motivation behind a patch
(along with the discussion that led to it).
It is easily trackable as the bugID in the Changelog is sufficient.
We used to have the policy to submit a patch to bugzilla before
applying it when CVS was still around.
For some reason people thought this to be unnecessary after modularization
and the change to git had taken place.

Cheers,
	Egbert.



More information about the xorg mailing list