[PATCH1/2] xf86-video-intel: fix ivch dvo register

Jesse Barnes jbarnes at virtuousgeek.org
Tue Feb 5 16:33:43 PST 2008


On Thursday, January 31, 2008 11:22 pm Hong Liu wrote:
> We use the wrong DVO output register for ivch which is used for DVO LVDS.
> Vbios enables DVOB and driver never touches it, so everything seems
> working correctly now.
> ---
>  src/i830_dvo.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/i830_dvo.c b/src/i830_dvo.c
> index e6ff6af..e7342b0 100644
> --- a/src/i830_dvo.c
> +++ b/src/i830_dvo.c
> @@ -83,7 +83,7 @@ struct _I830DVODriver i830_dvo_drivers[] =
>  	.type = I830_OUTPUT_DVO_LVDS,
>  	.modulename = "ivch",
>  	.fntablename = "ivch_methods",
> -	.dvo_reg = DVOA,
> +	.dvo_reg = DVOB,
>  	.address = 0x04, /* Might also be 0x44, 0x84, 0xc4 */
>  	.symbols = ivch_symbols
>      },

Apparently some machines need to use DVOA, so I expect we'll see some bug 
reports now that this has been pushed.  Since other machines need DVOB, we'll 
probably need to autodetect this situation somehow (VBT maybe?) or, failing 
that, add a new quirk.

Is that something you can do, Hong?  According to Keith, X30 is one machine 
where DVOA is needed.

Jesse



More information about the xorg mailing list