[PATCH 0/2] Keep generated glapi sources in mesa
dbn.lists at gmail.com
Thu Feb 14 09:44:28 PST 2008
On Thu, Feb 14, 2008 at 9:34 AM, Daniel Stone <daniel at fooishbar.org> wrote:
> On Thu, Feb 14, 2008 at 09:14:09AM -0800, Ian Romanick wrote:
> > Dan Nicholson wrote:
> > | The glapi source files for the xserver's GLX module are currently
> > | generated in the mesa tree and then manually merged into the the xserver
> > | tree. This step in the GLX build is error prone as the files can easily
> > | become unsynchronized from the rest of the glapi in mesa.
> > |
> > | This patchset changes the mesa build to generate the files in a standard
> > | location in the mesa tree. Likewise, the xserver glx build has the
> > | necessary files symlinked in by symlink-mesa.sh at build time.
> > |
> > | I put the files in src/glx/x11 in mesa with the rest of the glx sources.
> > | I'm not sure if this is the best place.
> > We used to do this before, back in the pre-modular days. The problem,
> > if I recall, was that when changes were made to GLX protocol code people
> > had to keep their Mesa and X.org trees in lock-step. Everyone hated that.
> I'm not really seeing the difference between then and now.
Caveat: I'm not going to try to pretend that I understand the GLX API at all.
In the current case it is worse (as far as I can tell). If the GLX API
changes in mesa, you then have to wait for someone to sync the
server-side files into xserver. With these patches, the changes are at
least localized to a single commit in mesa. Whether libglx can cope
with changes in the API wouldn't seem to be affected in either case.
More information about the xorg