[RFC] linking video drivers against -lpciaccess

Julien Cristau jcristau at debian.org
Fri Jun 6 04:50:08 PDT 2008


Hi,

I'd like to know if libpciaccess is considered part of the video driver
abi.
If yes, then we need to define which version, so drivers and server
agree on what is available.
If not (which IMO is saner), then I think drivers should link against
-lpciaccess directly.  If people agree with this I'm willing to update
the drivers (sample patch against -intel below).

(Rationale: right now only the server package gets a dependency on
libpciaccess.so.0, so if a function is added and only used by drivers
then an earlier version of libpciaccess would satisfy the dependencies
but break the driver.  Linking the drivers against the lib makes sure
they get the correct dependency.)

Cheers,
Julien

From: Julien Cristau <jcristau at debian.org>
Date: Fri, 6 Jun 2008 13:40:20 +0200
Subject: [PATCH] Link the driver with -lpciaccess if XSERVER_LIBPCIACCESS

This makes sure the driver ends up with a DT_NEEDED reference to
libpciaccess if it uses it.
---
 src/Makefile.am |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 0784c06..7c69899 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -36,6 +36,9 @@ AM_CFLAGS = @WARN_CFLAGS@ @XORG_CFLAGS@ @DRI_CFLAGS@ @PCIACCESS_CFLAGS@ \
 intel_drv_la_LTLIBRARIES = intel_drv.la
 intel_drv_la_LDFLAGS = -module -avoid-version
 intel_drv_ladir = @moduledir@/drivers
+if XSERVER_LIBPCIACCESS
+intel_drv_la_LIBADD = @PCIACCESS_LIBS@
+endif
 
 XMODE_SRCS=\
 	 local_xf86Rename.h \
-- 
1.5.5.3




More information about the xorg mailing list