[PATCH] evdev: Partly revert commit 42422d8f "Check for XINPUT ABI, parameters of InitValuatorClassRec have changed."

Peter Hutterer peter at cs.unisa.edu.au
Sat Jun 7 07:52:37 PDT 2008


On Sat, Jun 07, 2008 at 12:23:49PM +0200, Sven Wegener wrote:
> The commit 42422d8f has added compability for new ABI_XINPUT_VERSION, but 
> broke the code for current ABI versions. InitValuatorClassDeviceStruct 
> wants a function pointer, GetMotionEvents() doesn't even exist and leads 
> to "undefined symbol" failures.

oh bloody hell, how did I manage that... my apologies.

Fixes are pushed. I think for changes like this (where a patch is obviously
severely broken, and only a few lines too) it is better however to revert the
patch and then apply the new, correct one. So instead of directly pushing your
patch, I decided to do the above.

Thanks for the patch though!

Cheers,
  Peter




More information about the xorg mailing list