[PATCH] Xi: check all handlers before applying property changes.
peter.hutterer at who-t.net
Mon Oct 13 00:02:02 PDT 2008
On Sun, Oct 12, 2008 at 06:17:20PM +0200, Simon Thum wrote:
> Peter Hutterer wrote:
> > The patch I proposed does not make any guarantee over when a handler is
> > called. This automatically separates handlers so they cannot interfere with
> > each other, and dependency ordering is a nonissue, as you cannot rely on it to
> > begin with. Code that relies on other handlers should not end up in the
> > repository.
> Ok, if handlers can be kept independent, your solution is absolutely
> fine. Its also desirable to keep them independent.
> I'm just not sure this is the whole story. When we look at the axis
> inversion example, this is rather insufficient. And it provokes
> workarounds, such as those you described.
> I think the choice depends on how often conflicts occur and how hard it
> gets to deal with them. Unfortunately, I can't find my crystal sphere ;)
Thx. I just went ahead and pushed the patch. Since the whole thing is
server-internal anyway, it'll be easy to change if the need comes up later.
For now, the rule is that handlers should not touch anything outside of their
scope, and they cannot rely on being called in any particular order.
Let's see if that works. We got until december to find out I think :)
More information about the xorg