[PATCH 0/3] X Input 1.5 device properties (final patches)

Peter Hutterer peter.hutterer at who-t.net
Tue Sep 23 17:59:17 PDT 2008


On Tue, Sep 23, 2008 at 09:02:34PM +0200, Simon Thum wrote:
> one more thing: A Handler already consists of getter and setter, so  
> there's an incentive to abstracting 'hey thats my property' on the  
> handler side anyway. So why load deletion onto the setter as a special  
> case of modification? I think it would be cleaner to have an own  
> 'sub-handler' for deletion.
>
> Or, since 99% of in-server code will just protect its props (at least,  
> no other use case comes to my mind), we could make it a property flag  
> again. I understand you want to get rid of it, but I think this one  
> could save some code on the handlers side. Mostly code which isn't  
> exactly DRY.

Right, I can see your point. How about the patch below (untested)? It's on top
of the other patches and adds a DeleteProperty handler, and a deletable flag.

If deletable is FALSE, the prop can only be deleted by the server/a driver,
and even then only if all handlers agree.



More information about the xorg mailing list