[PATCH] xkb: Set sane build time XKB defaults
dbn.lists at gmail.com
Mon Jan 12 06:49:42 PST 2009
On Sat, Jan 10, 2009 at 4:43 AM, Daniel Stone <daniel at fooishbar.org> wrote:
> On Sat, Jan 10, 2009 at 02:40:04PM +0200, Daniel Stone wrote:
>> On Wed, Jan 07, 2009 at 08:27:39AM -0800, Dan Nicholson wrote:
>> > On Wed, Jan 7, 2009 at 7:44 AM, Daniel Stone <daniel at fooishbar.org> wrote:
>> > > NAK of sorts: I'd like to fix this properly. In particular, hardcoded
>> > > paths are not the way.
>> > Sure. However, as it stands on both master and 1.6-branch, all the DDX
>> > except Xorg start with these defaults. So, they have an invalid
>> > default model of "dflt" as far as I can tell. Also, the
>> > XKB_BASE_DIRECTORY setting could be dropped from this patch. It's
>> > always defined in configure, so the hardcoded /usr/share/X11/xkb
>> > should never actually get used.
>> > What did you have in mind to fix this properly?
>> Something like this?
> Or maybe even something like this, rather ...
Looks good. Oh, it looks like the binary [[ ]] shell operators slipped
in there at some point. Those are bash only, I think, and should be
fixed. But that's not part of this patch.
More information about the xorg