[PATCH] Patch to not fork/exec xkbcomp on X Server initialization
yanli at infradead.org
Mon Mar 30 04:55:59 PDT 2009
On Fri, Mar 27, 2009 at 11:17:14AM +1000, Peter Hutterer wrote:
> I think /var/cache instead of /var/lib is the better place to put the files.
OK, got it.
> > In this patch there are also corrections to wrongly used TAB for
> > indention of codes related to this function. If you don't like it I
> > can move them to another standalone patch.
> Yes, please always do things like that (if needed at all) in a separate patch.
> If you correct tab/space issues in the code you're modifying it doesn't
> matter much, but this patch is quite noisy.
> > I understood the difficulty of merging functions like this into
> > mainstream. Or if we need to add an option to make this behaviour
> > optional, rather than enabled by default. I'd like to follow on this
> > until people is happy with it.
> It's looking good from a first pass, but I'd really like to see the patches
> split into one containing just the actual changes. I'm happy to test it then.
Thanks. I'm sending the v2 patch soon replying this mail.
More information about the xorg