[Zeitgeist-bugs] [Bug 51875] Merge request for libzeitgeist2

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51875

--- Comment #6 from Michal Hruby <michal.mhr at gmail.com> 2012-07-31 11:05:18 UTC ---
(In reply to comment #4)
> Thanks! Updated...
> http://cgit.freedesktop.org/zeitgeist/zeitgeist/commit/?h=libzeitgeist2&id=bdc9db34f827aae42f1c74f74ce7ee2d8fba8f97
> 
> > Ultimately we should get rid of generated .c files
> > from the tarball, which means that this will stop working.
> Then ultimately you will update it to work with your "not generating .c file"
> changes :P.
> 
> > Looks like something's missing here :)
> Yey. I guess we can finish that in trunk.
> 

Ok.

> >> +// FIXME: private or something
> >> +public abstract class QueuedProxyWrapper : Object
> > s/public/internal/
> As discussed before, Vala doesn't support increasing visibility in subclasses,
> so we are stuck there.
> 

Fine.

> > Uhhh, this will end up being a field in the ProxyWrapper
> > struct, that's not nice :(
> Doesn't work.
> 

Make it work!

> > This doesn't look right, why isn't it liking with libzeitgeist?
> Why would it? (Feel free to change it)

I'm not going to block the merge on this...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.