[patch] fd leak in usb_proc_parse

David Zeuthen david at fubar.dk
Sun Sep 19 08:01:39 PDT 2004


On Sat, 2004-09-18 at 21:53 +0200, Sjoerd Simons wrote:
> Hi,
> 
>   usb_proc_parse() parses /proc/bus/usb/devices but never closes the FILE
>   struct, which obviously leads to a fd leak. Fixed in attached patch.
>  

Thanks, I've applied this. Btw, now that sysfs actually exports the
information we need (the patch for maxchild, devnum and version landed
in Linux 2.6.6-rc1 [1]), we should probably get rid of parsing
the /proc/bus/usb/devices file at all. Anyone got a patch? :-)

Thanks,
David

[1] : http://www.club.cc.cmu.edu/pub/linux/kernel/people/gregkh/usb/2.6/2.6.5/usb-core-19-2.6.5.patch


_______________________________________________
hal mailing list
hal at freedesktop.org
http://freedesktop.org/mailman/listinfo/hal



More information about the Hal mailing list