[Mesa-dev] [PATCH] i965: Fix hangs on HSW since the gen6 blorp fix.

Kenneth Graunke kenneth at whitecape.org
Mon May 6 23:44:14 PDT 2013


On 05/06/2013 09:02 PM, Eric Anholt wrote:
> The constant packets for gen6 are too small for gen7, and while IVB seems
> happy with them HSW blows up.  Just restore the HSW path to what it was
> before the gen6 change, by making gen7-specific functions to set up these
> stages.
> ---
>
> The alternative here would be to emit the correct lengths of packets
> in these new functions.  But we're not emitting constants for other
> disabled stages on gen7+, so I'm leaning toward this variant.

Actually, we are in the normal state upload path: gen7_disable_stages 
emits zero-filled 3DSTATE_CONSTANT_GS/HS/DS packets.  Given the hangs on 
Sandybridge, I think it'd be best to explicitly disable them all in 
blorp too.  It's definitely the safest approach, and not a ton of code.

--Ken


More information about the mesa-dev mailing list