[Mesa-dev] [PATCH 08/17] intle: Add an assert for glCopyTexSubImage() being called on MSAA buffers.

[Marek Olšák]

CopyTexSubImage can be called on a multisample renderbuffer if the
renderbuffer is part of the window-system framebuffer (i.e. comes from
the visual).

IIRC, the game Cogs uses it if both MSAA and Post Filters are enabled.

Marek

On Fri, May 24, 2013 at 10:56 PM, Eric Anholt <eric at anholt.net> wrote:
> This is just in case someone else trips over this due to our weird reuse
> of this code in glBlitFramebuffer().
> ---
>  src/mesa/drivers/dri/intel/intel_tex_copy.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/intel/intel_tex_copy.c b/src/mesa/drivers/dri/intel/intel_tex_copy.c
> index 94e90da..4a13b9a 100644
> --- a/src/mesa/drivers/dri/intel/intel_tex_copy.c
> +++ b/src/mesa/drivers/dri/intel/intel_tex_copy.c
> @@ -62,6 +62,12 @@ intel_copy_texsubimage(struct intel_context *intel,
>
>     intel_prepare_render(intel);
>
> +   /* glCopyTexSubImage() can't be called on multisampled renderbuffers or
> +    * textures.
> +    */
> +   assert(!irb->Base.Base.NumSamples);
> +   assert(!intelImage->base.Base.NumSamples);
> +
>     if (!intelImage->mt || !irb || !irb->mt) {
>        if (unlikely(INTEL_DEBUG & DEBUG_PERF))
>          fprintf(stderr, "%s fail %p %p (0x%08x)\n",
> --
> 1.8.3.rc0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev