xserver: Branch 'master'

Adam Jackson ajax at kemper.freedesktop.org
Tue Apr 14 07:57:39 PDT 2009


 os/xdmcp.c |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 0eb19f9437b7d8c19592e49eedb028771d300d80
Author: Adam Jackson <ajax at redhat.com>
Date:   Tue Apr 14 10:54:25 2009 -0400

    xdmcp: Don't crash on X -query with more than 255 IP addresses. (#20675)
    
    You could be more clever than this, but the wire protocol says this
    really is an array of not more than 255 ARRAY8, so it's not just a
    matter of changing the types.

diff --git a/os/xdmcp.c b/os/xdmcp.c
index cf95586..c1d650d 100644
--- a/os/xdmcp.c
+++ b/os/xdmcp.c
@@ -490,6 +490,8 @@ XdmcpRegisterConnection (
 	    return;
 	}
     }
+    if (ConnectionAddresses.length + 1 == 256)
+	return;
     newAddress = xalloc (addrlen * sizeof (CARD8));
     if (!newAddress)
 	return;


More information about the xorg-commit mailing list