[PATCH] Radeon driver fixes
benh at kernel.crashing.org
Thu Nov 11 23:11:08 PST 2004
On Fri, 2004-11-12 at 01:41 -0500, Hui Yu wrote:
> Hi Ben,
> I haven't got time to go through the code carefully; just some
> comments based on your questions in previous email about deriving
> DotClock in ValidateDDCMode.
> Basically with UseBiosDividers set, the panel should be initialized to
> whatever specified by BIOS. ValidateDDCMode shouldn't be used because
> mixing DDC information and Bios provided dividers may cause problems.
> In this case DotClock is not really used for mode validation, but for
> some utility programs to display valid mode information. If you want
> to UseBiosDividers flag for a PPC path and need to derive DotClock
> from DDC, you can probably add the code to GetLVDSInfo. After all you
> are collecting info, not validating mode. In fact, things like
> UpdatePanelSize should go there too...
Thinking again ... I think you are right, it's best to move
UpdatePanelSize and friends there, collecting infos, even if that means
doing 2 iterations through the DDC info, that will make things simpler &
clearer. I'll work on that next week.
Then, ValidateDDCMode becomes a simple mode collection again. BTW, I
fail to see how it would harm calling it with UseBIOSDividers since
basically the mode will only be an x/y scale to apply to the RMX ... Or
was it because UpdatePanelSize(), when called by ValidateDDCMode(),
could eventually override panel infos with incorrect data from DDC ?
(Which I tried to avoid in my patch).
More information about the xorg