[PATCH 01/13] drm/amdgpu: Add virtual connector and encoder macros.

[Daniel Vetter]

I have no idea or clue on this, but adding dri-devel can't hurt.
-Daniel

On Thu, Aug 4, 2016 at 9:47 AM, Christian König <deathsimple at vodafone.de> wrote:
> Hi guys,
>
> yeah good idea, I was about to complain as well. Especially since we can't
> be sure if the design of this will be accepted or not.
>
> Dave & Daniel please take a look at this. It's basically the same approach
> we have seen with the virtual crtc patch set a couple of years ago, e.g.
> adding a virtual connector/encoder/crtc when there isn't any real one
> present.
>
> This allows to start X (or any other userspace client) even on boards which
> doesn't have any connectors in their BIOS tables.
>
> Intel does this by adding a virtual crtc in their DDX if I'm not completely
> mistaken, but we wanted a solution which works with any userspace client.
>
> I only briefly skimmed over the set and can't say much about this part of
> the driver anyway, but things like coding style looks good to me on first
> glance. So the whole set is Acked-by: Christian König
> <christian.koenig at amd.com>.
>
> Regards,
> Christian.
>
> Am 04.08.2016 um 08:52 schrieb Huang Rui:
>>
>> Hi Emily,
>>
>> Maybe, you need a cover letter to describe what you do for the whole patch
>> set. :-)
>>
>> git format-patch --cover-letter HEAD~13
>>
>> Thanks,
>> Rui
>>
>> On Thu, Aug 04, 2016 at 11:42:41AM +0800, Emily Deng wrote:
>>>
>>> For virtual display feature, add virtual connector and encoder macros.
>>>
>>> Signed-off-by: Emily Deng <Emily.Deng at amd.com>
>>> ---
>>>   drivers/gpu/drm/amd/amdgpu/ObjectID.h | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/ObjectID.h
>>> b/drivers/gpu/drm/amd/amdgpu/ObjectID.h
>>> index 0619269..b8d6667 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/ObjectID.h
>>> +++ b/drivers/gpu/drm/amd/amdgpu/ObjectID.h
>>> @@ -90,6 +90,7 @@
>>>   #define ENCODER_OBJECT_ID_INTERNAL_VCE            0x24
>>>   #define ENCODER_OBJECT_ID_INTERNAL_UNIPHY3        0x25
>>>   #define ENCODER_OBJECT_ID_INTERNAL_AMCLK          0x27
>>> +#define ENCODER_OBJECT_ID_VIRTUAL                 0x28
>>>     #define ENCODER_OBJECT_ID_GENERAL_EXTERNAL_DVO    0xFF
>>>   @@ -119,6 +120,7 @@
>>>   #define CONNECTOR_OBJECT_ID_eDP                   0x14
>>>   #define CONNECTOR_OBJECT_ID_MXM                   0x15
>>>   #define CONNECTOR_OBJECT_ID_LVDS_eDP              0x16
>>> +#define CONNECTOR_OBJECT_ID_VIRTUAL               0x17
>>>     /* deleted */
>>>   @@ -147,6 +149,7 @@
>>>   #define GRAPH_OBJECT_ENUM_ID5                     0x05
>>>   #define GRAPH_OBJECT_ENUM_ID6                     0x06
>>>   #define GRAPH_OBJECT_ENUM_ID7                     0x07
>>> +#define GRAPH_OBJECT_ENUM_VIRTUAL                 0x08
>>>     /****************************************************/
>>>   /* Graphics Object ID Bit definition                */
>>> @@ -408,6 +411,10 @@
>>>                                                     GRAPH_OBJECT_ENUM_ID1
>>> << ENUM_ID_SHIFT |\
>>>
>>> ENCODER_OBJECT_ID_HDMI_ANX9805 << OBJECT_ID_SHIFT)
>>>   +#define ENCODER_VIRTUAL_ENUM_VIRTUAL            (
>>> GRAPH_OBJECT_TYPE_ENCODER << OBJECT_TYPE_SHIFT |\
>>> +
>>> GRAPH_OBJECT_ENUM_VIRTUAL << ENUM_ID_SHIFT |\
>>> +
>>> ENCODER_OBJECT_ID_VIRTUAL << OBJECT_ID_SHIFT)
>>> +
>>>   /****************************************************/
>>>   /* Connector Object ID definition - Shared with BIOS */
>>>   /****************************************************/
>>> --
>>> 1.9.1
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
>
>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch