[PATCH 07/14] drm/amd/powerplay: remove enable_clock_power_gatings_tasks from initialize and resume events
Eric Huang
jinhuieric.huang at amd.com
Mon Aug 8 20:59:07 UTC 2016
Hi Tom,
I am concerned with the Sclk Deep Sleep feature. If removing this task,
UVD/VCE will always power on and Sclk deep sleep will not work. And the
power consumption will block our client's Energy start test. So where
are you going to re-add this task ?
Thanks,
Eric
On 16-07-28 10:19 AM, Tom St Denis wrote:
> Setting PG state this early would cause lock ups in the IP block
> initialized functions.
>
> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/eventmgr/eventactionchains.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/eventmgr/eventactionchains.c b/drivers/gpu/drm/amd/powerplay/eventmgr/eventactionchains.c
> index d6635cc4b0fc..635fc4b48184 100644
> --- a/drivers/gpu/drm/amd/powerplay/eventmgr/eventactionchains.c
> +++ b/drivers/gpu/drm/amd/powerplay/eventmgr/eventactionchains.c
> @@ -30,7 +30,6 @@ static const pem_event_action * const initialize_event[] = {
> system_config_tasks,
> setup_asic_tasks,
> enable_dynamic_state_management_tasks,
> - enable_clock_power_gatings_tasks,
> get_2d_performance_state_tasks,
> set_performance_state_tasks,
> initialize_thermal_controller_tasks,
> @@ -140,7 +139,6 @@ static const pem_event_action * const resume_event[] = {
> setup_asic_tasks,
> enable_stutter_mode_tasks, /*must do this in boot state and before SMC is started */
> enable_dynamic_state_management_tasks,
> - enable_clock_power_gatings_tasks,
> enable_disable_bapm_tasks,
> initialize_thermal_controller_tasks,
> get_2d_performance_state_tasks,
More information about the amd-gfx
mailing list