[PATCH 00/19] shadow page table support V2

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Wednesday, August 10, 2016 7:14 AM
> To: Zhou, David(ChunMing); amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH 00/19] shadow page table support V2
> 
> Am 10.08.2016 um 08:02 schrieb zhoucm1:
> >
> >
> > On 2016年08月08日 19:04, Christian König wrote:
> >> I need to work on the S3 issue again now, going to come back to this
> >> patch set when I have more time.
> > I've addressed your previous comments, are you free?
> 
> Well if you figure out why the heck the UVD engine sometimes crashes
> since I changed how usage is detected I'm all yours :)
> 
> > how about the other patches?
> 
> They looked rather good to me, maybe Alex or somebody else could take a
> look as well.
> 
> What you should keep in mind is a) please try to avoid using the
> scheduler for recovery, I really don't like the idea that we start to
> mess with userspace submissions before anything else is stable again.
> 
> And b) when we use the same reservation object for two BOs we need to
> set the parent, otherwise we can run into a race which gets freed first.
> That applies even when the BOs are reference counted like your shadow
> BOs are.
> 

The patches look ok to me as well.  I agree with Christian about avoiding the scheduler for recovery.

Alex

> >
> > Thanks,
> > David Zhou
> >>
> >> Regards,
> >> Christian.
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx