[PATCH 5/8] drm/amdgpu: update pt shadow while updating pt V2
Chunming Zhou
David1.Zhou at amd.com
Wed Aug 17 06:05:16 UTC 2016
V2:
move shadow parameter to amdgpu_pte_update_params.
Change-Id: Ibc8fb4c5c9be38934ebd6d56f1cbd49cb82d53af
Signed-off-by: Chunming Zhou <David1.Zhou at amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index c5a782f..f1bf57b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -66,6 +66,8 @@ struct amdgpu_pte_update_params {
dma_addr_t *pages_addr;
/* indirect buffer to fill with commands */
struct amdgpu_ib *ib;
+ /* indicate upodate pt or its shadow */
+ bool shadow;
};
/**
@@ -748,7 +750,8 @@ static void amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
/* initialize the variables */
addr = start;
pt_idx = addr >> amdgpu_vm_block_size;
- pt = vm->page_tables[pt_idx].entry.robj;
+ pt = params->shadow ? vm->page_tables[pt_idx].entry.robj->shadow :
+ vm->page_tables[pt_idx].entry.robj;
if ((addr & ~mask) == (end & ~mask))
nptes = end - addr;
@@ -767,7 +770,8 @@ static void amdgpu_vm_update_ptes(struct amdgpu_pte_update_params *params,
/* walk over the address space and update the page tables */
while (addr < end) {
pt_idx = addr >> amdgpu_vm_block_size;
- pt = vm->page_tables[pt_idx].entry.robj;
+ pt = params->shadow ? vm->page_tables[pt_idx].entry.robj->shadow :
+ vm->page_tables[pt_idx].entry.robj;
if ((addr & ~mask) == (end & ~mask))
nptes = end - addr;
@@ -948,6 +952,9 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev,
ndw += 2 * 10;
}
+ /* double ndw, since need to update shadow pt bo as well */
+ ndw *= 2;
+
r = amdgpu_job_alloc_with_ib(adev, ndw * 4, &job);
if (r)
return r;
@@ -967,6 +974,9 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev,
if (r)
goto error_free;
+ params.shadow = true;
+ amdgpu_vm_frag_ptes(¶ms, vm, start, last + 1, addr, flags);
+ params.shadow = false;
amdgpu_vm_frag_ptes(¶ms, vm, start, last + 1, addr, flags);
amdgpu_ring_pad_ib(ring, params.ib);
--
1.9.1
More information about the amd-gfx
mailing list