[PATCH 0/6] make ctx mgr global

[Liu, Monk]

Yeah, I was already doing that

-----Original Message-----
From: Christian König [mailto:deathsimple at vodafone.de] 
Sent: Thursday, August 25, 2016 4:08 PM
To: Liu, Monk <Monk.Liu at amd.com>; Zhou, David(ChunMing) <David1.Zhou at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Mao, David <David.Mao at amd.com>
Subject: Re: [PATCH 0/6] make ctx mgr global

Yeah, I wouldn't mind a patch renaming ctx to fence_context in the job and rign structure.

This way we make it clear what is used here.

Christian.

Am 25.08.2016 um 05:38 schrieb Liu, Monk:
> Sorry,
>
> I don't mean ctx-id, I'm talking about "job->ctx", which is a 
> atomic_64t value, and it is initiated from entity->fence_context, As 
> long as fence_context is unique cross whole system, we are safe to use it to judge context switch, I checked again the code, this fence_context is already globally unique, so never mind, our current code is okay!
>
> Thanks
> BR Monk
>
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf 
> Of Christian K?nig
> Sent: Wednesday, August 24, 2016 8:21 PM
> To: Liu, Monk <Monk.Liu at amd.com>; Zhou, David(ChunMing) 
> <David1.Zhou at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Mao, David <David.Mao at amd.com>
> Subject: Re: [PATCH 0/6] make ctx mgr global
>
> The context number isn't used for judgment if a switch is needed or not (or at least it shouldn't be).
>
> The numbers are just and IDR, e.g. they are just used to identify a kernel object from userspace.
>
> Regards,
> Christian.
>
> Am 24.08.2016 um 12:45 schrieb Liu, Monk:
>> David,
>>
>> No matter what's the initial purpose of this patch is, I think this 
>> patch is needed, otherwise context switch judgment will be incorrect 
>> , e.g. process1 and process2 can both have a context id 99, and that 
>> will Lead to incorrect skipping of PREAMBLE CE IB
>>
>> BR monk
>>
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On 
>> Behalf Of Chunming Zhou
>> Sent: Thursday, August 18, 2016 3:50 PM
>> To: amd-gfx at lists.freedesktop.org
>> Cc: Zhou, David(ChunMing) <David1.Zhou at amd.com>; Mao, David 
>> <David.Mao at amd.com>
>> Subject: [PATCH 0/6] make ctx mgr global
>>
>> If we want to share semaphore/dependency across process across device, we must make ctx id be global, so that we can index it everywhere.
>>
>> Chunming Zhou (6):
>>     drm/amdgpu: use global ctx mgr instead of vm specified
>>     drm/amdgpu: clean up for amdgpu ctx
>>     drm/amdgpu: allocate progressively higher ids for ctx until idr
>>       counter wraps
>>     drm/amdgpu: ctx id should be removed when ctx is freed
>>     drm/amdgpu: use fence-array for ctx release
>>     drm/amdgpu: dependency is already signaled if ctx has been freed
>>
>>    drivers/gpu/drm/amd/amdgpu/amdgpu.h     |  17 ++--
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c  |   9 +-
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 142 ++++++++++++++++++--------------
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |   3 +
>>    drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c |   4 -
>>    5 files changed, 92 insertions(+), 83 deletions(-)
>>
>> --
>> 1.9.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx