[PATCH] drm/amd/powerplay: use pr_debug to print function not implemented message

Edward O'Callaghan funfunctor at folklore1984.net
Thu Dec 8 00:36:57 UTC 2016


Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 12/08/2016 06:28 AM, Alex Deucher wrote:
> From: Arindam Nath <arindam.nath at amd.com>
> 
> For CZ, some function pointers like display_configuration_changed
> are not set. So when HW manager tries to configure display, we
> end up with messages like
> 
> "[ powerplay ] this function not implement!"
> 
> in the logs. This message is informational, but lacks details
> on which function is not implemented and why.
> 
> Rather than using KERN_INFO to print the message everytime the
> system boots, we rather use pr_debug so that it is only printed
> when debug prints are enabled at runtime.
> 
> Reviewed-by: Huang Rui <ray.huang at amd.com>
> Signed-off-by: Arindam Nath <arindam.nath at amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> index a6abe81..71822ae 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c
> @@ -35,7 +35,7 @@ static int phm_run_table(struct pp_hwmgr *hwmgr,
>  	phm_table_function *function;
>  
>  	if (rt_table->function_list == NULL) {
> -		printk(KERN_INFO "[ powerplay ] this function not implement!\n");
> +		pr_debug("[ powerplay ] this function not implement!\n");
>  		return 0;
>  	}
>  
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161208/b06d4adf/attachment.sig>


More information about the amd-gfx mailing list