[PATCH 04/12] drm/amd/display: remove DM_NOT_IMPL messages

Harry Wentland harry.wentland at amd.com
Thu Dec 8 01:26:16 UTC 2016


From: Arindam Nath <arindam.nath at amd.com>

Some functions like dm_bandwidth_update are placeholders
for future implementations. Right now, they simply
print messages like "DM_NOT_IMPL: dm_bandwidth_update".
This message even though informational, sometimes can
create some confusion for users.

Since these functions are only skeletons for future, we
simply remove the rather un-unecessary messages from these
functions.

Change-Id: I6e5fdcaff4cd91e1b905d7aa4b0cd47a44685a79
Signed-off-by: Arindam Nath <arindam.nath at amd.com>
Reviewed-by: Christian König <christian.koenig at amd.com>
Reviewed-by: Harry Wentland <Harry.Wentland at amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index a4a6269b9b6b..70d6e4168b31 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -54,10 +54,6 @@
 
 #include "modules/inc/mod_freesync.h"
 
-/* Debug facilities */
-#define AMDGPU_DM_NOT_IMPL(fmt, ...) \
-	DRM_INFO("DM_NOT_IMPL: " fmt, ##__VA_ARGS__)
-
 /*
  * dm_vblank_get_counter
  *
@@ -1277,20 +1273,18 @@ void amdgpu_dm_destroy_drm_device(struct amdgpu_display_manager *dm)
  */
 static void dm_bandwidth_update(struct amdgpu_device *adev)
 {
-	AMDGPU_DM_NOT_IMPL("%s\n", __func__);
+	/* TODO: implement later */
 }
 
 static void dm_set_backlight_level(struct amdgpu_encoder *amdgpu_encoder,
 				     u8 level)
 {
 	/* TODO: translate amdgpu_encoder to display_index and call DAL */
-	AMDGPU_DM_NOT_IMPL("%s\n", __func__);
 }
 
 static u8 dm_get_backlight_level(struct amdgpu_encoder *amdgpu_encoder)
 {
 	/* TODO: translate amdgpu_encoder to display_index and call DAL */
-	AMDGPU_DM_NOT_IMPL("%s\n", __func__);
 	return 0;
 }
 
-- 
2.9.3



More information about the amd-gfx mailing list