[PATCH 0/4] drm/amd/powerplay: introduce the cgs print helpers

Christian König christian.koenig at amd.com
Thu Dec 8 08:41:04 UTC 2016


Sorry, but that just sounds like OS abstraction code which isn't allowed.

There is no benefit except routing all messages through CGS which makes 
things much harder to follow.

Regards,
Christian.

Am 08.12.2016 um 06:23 schrieb Huang Rui:
> From: Huang Rui <Ray.Huang at amd.com>
>
> Hi all,
>
> These patch set adds the helpers of print in CGS. Powerplay will be
> used them instead of raw printk, and we can dynamic change the debug
> level with it.
>
> The prefix is like below:
>
> [  310.200991] amdgpu 0000:01:00.0: [powerplay] ...
>
> Thanks,
> Rui
>
> Huang Rui (4):
>    drm/amdgpu: introduce the cgs print helpers
>    drm/amd/powerplay: update printk to cgs debug prints for smumgr
>    drm/amd/powerplay: update printk to cgs debug prints for common part
>    drm/amd/powerplay: update printk to cgs debug prints for hwmgr
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c            | 26 +++++++++++-
>   drivers/gpu/drm/amd/include/cgs_common.h           | 24 +++++++++++
>   drivers/gpu/drm/amd/powerplay/amd_powerplay.c      | 49 +++++++++++-----------
>   drivers/gpu/drm/amd/powerplay/eventmgr/eventinit.c |  2 +-
>   drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c     | 26 ++++++------
>   .../gpu/drm/amd/powerplay/hwmgr/functiontables.c   | 14 +++----
>   drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c        |  8 ++--
>   drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c   |  6 +--
>   .../amd/powerplay/hwmgr/process_pptables_v1_0.c    |  4 +-
>   drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c   | 26 ++++++------
>   .../gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c   |  2 +-
>   drivers/gpu/drm/amd/powerplay/inc/pp_debug.h       | 14 +++----
>   drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c   | 28 ++++++-------
>   drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c    |  4 +-
>   drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c |  8 ++--
>   drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 16 +++----
>   .../gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c  |  2 +-
>   .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c   |  4 +-
>   .../drm/amd/powerplay/smumgr/polaris10_smumgr.c    |  8 ++--
>   drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 16 +++----
>   drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c   | 14 +++----
>   .../gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c    |  2 +-
>   22 files changed, 176 insertions(+), 127 deletions(-)
>



More information about the amd-gfx mailing list