[PATCH 10/12] drm/amd/display: avoid apply_clk_constraints for address update

[Kai Wasserbäch]

Harry Wentland wrote on 08.12.2016 17:47:
> Alex's tree isn't fully in sync yet.
> 
> This is currently only used by code for unreleased ASICs, so the public code
> won't use it (yet).

ok, though that seems turned around. Why not squash this into the enablement
series for the as of yet unreleased ASICs ("uGPU" from the other thread, I assume?)

Cheers,
Kai

> On 2016-12-08 11:39 AM, Kai Wasserbäch wrote:
>> [Please CC me on all replies, I'm not subscribed to the list.]
>>
>> Harry Wentland wrote on 08.12.2016 02:26:
>>> From: Tony Cheng <tony.cheng at amd.com>
>>>
>>> - dc_update_surfaces_for_target get called in ISR but apply_clk_constraints
>>> allocates memory
>>>
>>> Change-Id: I9f4b7b6ca4af27c35c007e3af95111081a77d242
>>> Signed-off-by: Tony Cheng <tony.cheng at amd.com>
>>> Reviewed-by: Dmytro Laktyushkin <Dmytro.Laktyushkin at amd.com>
>>> Acked-by: Harry Wentland <Harry.Wentland at amd.com>
>>> ---
>>>   drivers/gpu/drm/amd/display/dc/core/dc.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> index 70b7673993b2..522ef7047564 100644
>>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>>> @@ -1336,6 +1336,7 @@ void dc_update_surfaces_for_target(struct dc *dc,
>>> struct dc_surface_update *upda
>>>       int i, j;
>>>       bool is_new_pipe_surface[MAX_PIPES];
>>>       const struct dc_surface *new_surfaces[MAX_SURFACES] = { 0 };
>>> +    bool need_apply_clk_constraints = false;
>>>         update_surface_trace(dc, updates, surface_count);
>>>   @@ -1405,6 +1406,7 @@ void dc_update_surfaces_for_target(struct dc *dc,
>>> struct dc_surface_update *upda
>>>                 if (updates[i].plane_info || updates[i].scaling_info
>>>                       || is_new_pipe_surface[j]) {
>>> +                need_apply_clk_constraints = true;
>> Where is this variable used? I grepped through the tree at
>> <https://cgit.freedesktop.org/~agd5f/linux/tree/drivers/gpu/drm/amd?h=amd-staging-4.7>,
>>
>> but couldn't find it anywhere and it doesn't get passed anywhere from here. Or
>> are there patches missing in Alex' tree?
>>
>> Cheers,
>> Kai
>>
>>>                   if (updates[i].plane_info) {
>>>                       surface->public.color_space =
>>>
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

-- 

Kai Wasserbäch (Kai Wasserbaech)

E-Mail: kai at dev.carbon-project.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161208/6e5eb534/attachment.sig>