[PATCH 02/22] drm/amd/display: Refactor to move color helper into module

Andreas Boll andreas.boll.dev at gmail.com
Wed Dec 21 17:21:15 UTC 2016


Hi,

2016-12-21 17:29 GMT+01:00 Harry Wentland <harry.wentland at amd.com>:
> From: Anthony Koo <Anthony.Koo at amd.com>
>
> Refactor part 2 - Moving color helper into color module
>
> The color module will need table defined in the helper in order to calculate
> the logical regamma curve, and also to fully handle gamut remapping.
>
> Change-Id: I826335cd42a9d5d0a872f9206fae83daeb1c45a6
> Signed-off-by: Anthony Koo <anthony.koo at amd.com>
> Reviewed-by: Aric Cyr <Aric.Cyr at amd.com>
> Acked-by: Harry Wentland <Harry.Wentland at amd.com>
> ---
>  .../drm/amd/display/modules/color/color_helper.c   | 199 +++++++++++++++++++++
>  .../drm/amd/display/modules/color/color_helper.h   |  50 ++++++
>  .../gpu/drm/amd/display/modules/inc/mod_color.h    |   4 +-
>  3 files changed, 251 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/gpu/drm/amd/display/modules/color/color_helper.c
>  create mode 100644 drivers/gpu/drm/amd/display/modules/color/color_helper.h
>
> diff --git a/drivers/gpu/drm/amd/display/modules/color/color_helper.c b/drivers/gpu/drm/amd/display/modules/color/color_helper.c
> new file mode 100644
> index 000000000000..c47d2962c6d4
> --- /dev/null
> +++ b/drivers/gpu/drm/amd/display/modules/color/color_helper.c
> @@ -0,0 +1,199 @@
> +
> +/**
> + *  @file
> + *  @date Copyright (c) 2008 Advanced Micro Devices, Inc. (unpublished)
> + *
> + *  @brief Helper functions for color gamut calculation
> + *
> + *  @internal
> + *  All rights reserved.  This notice is intended as a precaution against
> + *  inadvertent publication and does not imply publication or any waiver
> + *  of confidentiality.  The year included in the foregoing notice is the
> + *  year of creation of the work.
> + */

This copyright header needs to be fixed.

> diff --git a/drivers/gpu/drm/amd/display/modules/color/color_helper.h b/drivers/gpu/drm/amd/display/modules/color/color_helper.h
> new file mode 100644
> index 000000000000..c0e6334b947e
> --- /dev/null
> +++ b/drivers/gpu/drm/amd/display/modules/color/color_helper.h
> @@ -0,0 +1,50 @@
> +/**
> + *  @file
> + *  @date Copyright (c) 2008 Advanced Micro Devices, Inc. (unpublished)
> + *
> + *  @brief Helper functions for color gamut calculation
> + *
> + *  @internal
> + *  All rights reserved.  This notice is intended as a precaution against
> + *  inadvertent publication and does not imply publication or any waiver
> + *  of confidentiality.  The year included in the foregoing notice is the
> + *  year of creation of the work.
> + */

same here

Thanks,
Andreas


More information about the amd-gfx mailing list