[PATCH v2 0/6] drm/amd/powerplay: refine pr_* prints for powerplay

Edward O'Callaghan funfunctor at folklore1984.net
Mon Dec 26 08:02:59 UTC 2016


Merry Christmas Huang Rui,

This set looks way better and a much more complete solution, good job
working though it all!

Patches 1-6 are,
Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>

Kindest Regards,
Edward.

On 12/26/2016 06:56 PM, Huang Rui wrote:
> From: Huang Rui <Ray.Huang at amd.com>
> 
> Hi all,
> 
> Merry Christmas! No one generate patches at this time except us :-).
> 
> The following patch set doesn't have any function change, just refine
> prints of powerplay. Powerplay will used pr_* instead of raw printk,
> and we can dynamic change the debug level with it.
> 
> The prefix is like below:
> 
> [  xxx.xxxxxx] amdgpu: [powerplay] ...
> 
> Best Wishes,
> Rui
> 
> Huang Rui (6):
>   drm/amd/powerplay: add prefix for all powerplay pr_* prints
>   drm/amd/powerplay: reshuffle headers to make pr_fmt macro before
>     <linux/xxx.h>
>   drm/amd/powerplay: refine print message for amd_powerplay
>   drm/amd/powerplay: update all printk to pr_* on eventmgr
>   drm/amd/powerplay: update all printk to pr_* on hwmgr
>   drm/amd/powerplay: update all printk to pr_* on smumgr
> 
>  drivers/gpu/drm/amd/powerplay/amd_powerplay.c      | 50 +++++++++++-----------
>  drivers/gpu/drm/amd/powerplay/eventmgr/eventinit.c |  2 +-
>  drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c     | 29 ++++++-------
>  .../gpu/drm/amd/powerplay/hwmgr/functiontables.c   | 14 +++---
>  .../gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c  |  2 +-
>  drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c        | 11 ++---
>  drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c   |  8 ++--
>  .../amd/powerplay/hwmgr/process_pptables_v1_0.c    |  6 +--
>  .../gpu/drm/amd/powerplay/hwmgr/processpptables.c  |  2 +-
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c   | 28 ++++++------
>  .../gpu/drm/amd/powerplay/hwmgr/smu7_powertune.c   |  4 +-
>  drivers/gpu/drm/amd/powerplay/inc/pp_debug.h       | 10 ++++-
>  drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c   | 28 ++++++------
>  drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c    |  6 +--
>  drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 10 ++---
>  drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 10 ++---
>  .../gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c  |  4 +-
>  .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c   |  6 +--
>  .../drm/amd/powerplay/smumgr/polaris10_smumgr.c    | 10 ++---
>  drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 14 +++---
>  drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c   | 16 +++----
>  .../gpu/drm/amd/powerplay/smumgr/tonga_smumgr.c    |  4 +-
>  22 files changed, 140 insertions(+), 134 deletions(-)
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161226/30c35c18/attachment.sig>


More information about the amd-gfx mailing list