[PATCH 2/2] drm/amd/amdgpu: Add PG support for Carrizo UVD

StDenis, Tom Tom.StDenis at amd.com
Fri Jul 8 00:53:14 UTC 2016


Should point out that under load the system isn't 100% stable just yet.


One thing I noted is that it will powerdown/up between frames it seems (by reading the PGFSM_CONFIG register) which it shouldn't be doing in a static configuration.


I wonder if it's powering down at bad times while under load?


Tom

________________________________
From: Tom St Denis <tstdenis82 at gmail.com>
Sent: Thursday, July 7, 2016 20:47
To: amd-gfx at lists.freedesktop.org
Cc: StDenis, Tom
Subject: [PATCH 2/2] drm/amd/amdgpu: Add PG support for Carrizo UVD

Signed-off-by: Tom St Denis <tom.stdenis at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index 91d71e31d6db..d2421867014f 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -1580,13 +1580,17 @@ static int vi_common_early_init(void *handle)
                         AMD_CG_SUPPORT_SDMA_LS;
                 /* rev0 hardware doesn't support PG */
                 adev->pg_flags = 0;
-               if (adev->rev_id != 0x00)
+               if (adev->rev_id != 0x00) {
                         adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |
                                 AMD_PG_SUPPORT_GFX_SMG |
                                 AMD_PG_SUPPORT_GFX_DMG |
                                 AMD_PG_SUPPORT_CP |
                                 AMD_PG_SUPPORT_RLC_SMU_HS |
                                 AMD_PG_SUPPORT_GFX_PIPELINE;
+                       /* powerplay UVD PG doesn't work yet */
+                       if (!amdgpu_powerplay)
+                               adev->pg_flags |= AMD_PG_SUPPORT_UVD;
+               }
                 adev->external_rev_id = adev->rev_id + 0x1;
                 break;
         case CHIP_STONEY:
--
2.9.0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160708/eb95760f/attachment.html>


More information about the amd-gfx mailing list