[PATCH] drm/amdgpu: increase timeout of IB test
deathsimple at vodafone.de
Tue Jul 26 07:32:29 UTC 2016
Ok, I really wasn't expecting this. How about 100ms?
I just want to avoid that a reset takes more than 1 or 2 seconds even
when it didn't worked.
With 1 second timeout for each IB test we easily need 10+ seconds when
the hardware doesn't response at all.
Am 26.07.2016 um 09:28 schrieb zhoucm1:
> CQE has found timeout when they cherry-pick your timeout patch.
> I also found ib_test could be timeout after gpu reset.
> 1s maybe too long for a simple testing command, but I just think that
> doesn't matter to judge timeout.
> On 2016年07月26日 15:24, Christian König wrote:
>> Am 26.07.2016 um 07:57 schrieb Chunming Zhou:
>>> we should give enough time to IB test.
>>> Change-Id: I92bfbe9b3aa35083f41baed8663907abfa15c8e6
>>> Signed-off-by: Chunming Zhou <David1.Zhou at amd.com>
>> Do we really need more than 10ms for an IB test? A whole second
>> sounds awful long when we need to do 10+ tests currently.
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
>>> index 050062e..a31d7ef 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
>>> @@ -33,7 +33,7 @@
>>> #include "amdgpu.h"
>>> #include "atom.h"
>>> -#define AMDGPU_IB_TEST_TIMEOUT msecs_to_jiffies(10)
>>> +#define AMDGPU_IB_TEST_TIMEOUT msecs_to_jiffies(1000)
>>> * IB
More information about the amd-gfx