[PATCH] drm/radeon: drop confusing message about backlight control

Alexandre Demers alexandre.f.demers at gmail.com
Thu Jul 28 03:24:44 UTC 2016


Reviewed-by: Alexandre Demers <alexandre.f.demers at gmail.com>

Alexandre Demers

On 2016-07-27 16:44, Alex Deucher wrote:
> The message is harmless and confusing.  On PX systems,
> there is one ATIF method, but potentially multiple GPUs
> leading to an error on the GPU with no backlight control.
>
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=115011
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> Cc: Hans de Goede <jwrdegoede at fedoraproject.org>
> ---
>   drivers/gpu/drm/radeon/radeon_acpi.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_acpi.c b/drivers/gpu/drm/radeon/radeon_acpi.c
> index 59acd0e..31c9a92 100644
> --- a/drivers/gpu/drm/radeon/radeon_acpi.c
> +++ b/drivers/gpu/drm/radeon/radeon_acpi.c
> @@ -741,13 +741,6 @@ int radeon_acpi_init(struct radeon_device *rdev)
>   		}
>   
>   		atif->encoder_for_bl = target;
> -		if (!target) {
> -			/* Brightness change notification is enabled, but we
> -			 * didn't find a backlight controller, this should
> -			 * never happen.
> -			 */
> -			DRM_ERROR("Cannot find a backlight controller\n");
> -		}
>   	}
>   
>   	if (atif->functions.sbios_requests && !atif->functions.system_params) {



More information about the amd-gfx mailing list