[PATCH xf86-video-amdgpu 2/3] Remove w/h parameters from amdgpu_scanout_extents_intersect

Alex Deucher alexdeucher at gmail.com
Mon Jun 27 16:04:01 UTC 2016


On Sun, Jun 26, 2016 at 11:53 PM, Michel Dänzer <michel at daenzer.net> wrote:
> On 24.06.2016 23:13, Deucher, Alexander wrote:
>>> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
>>> Of Michel Dänzer
>>> [...]
>>> We can use the dimensions of the CRTC's mode instead.
>>
>> Will this break panning mode?
>
> No, panning still works fine with this change. These dimensions are just
> used for clamping the extents of damage after it was transformed into
> the CRTC coordinate space. When panning, drmmode_set_mode_major damages
> the whole virtual screen, which in this code results in the transformed
> and clamped extents still covering the whole CRTC, so the scanout pixmap
> gets updated with the contents of the CRTC viewport at the new position.
>

Thanks for explaining.  The patch set is:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

>
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list