[PATCH 2/7] drm/amdgpu: remove duplicated job free

Christian König deathsimple at vodafone.de
Wed Jun 29 08:51:54 UTC 2016


Am 29.06.2016 um 10:09 schrieb Chunming Zhou:
> Change-Id: I342f5993766a3eb5be1116a0f6846fe4a445fd30
> Signed-off-by: Chunming Zhou <David1.Zhou at amd.com>

NAK, this is for the cleanup handling when the job isn't submitted 
because of an error.

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index d16ed26..5886768 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -577,8 +577,6 @@ static void amdgpu_cs_parser_fini(struct amdgpu_cs_parser *parser, int error, bo
>   	for (i = 0; i < parser->nchunks; i++)
>   		drm_free_large(parser->chunks[i].kdata);
>   	kfree(parser->chunks);
> -	if (parser->job)
> -		amdgpu_job_free(parser->job);
>   	amdgpu_bo_unref(&parser->uf_entry.robj);
>   }
>   



More information about the amd-gfx mailing list