[PATCH] drm/amd/powerplay: functions's return state was reversed

Alex Deucher alexdeucher at gmail.com
Wed Jun 29 19:49:39 UTC 2016


On Wed, Jun 29, 2016 at 7:32 AM, Rex Zhu <Rex.Zhu at amd.com> wrote:
> In commit 195567e99bdf6491a370b71a1dcf6b4c891495d7,
> use true/false instead of 1/0 to fix build warning.
> But the original logic: '0' means true and '1' means false.
>
> Change-Id: Ic4ed05f5a750f208674a90626ae5d3e76cce22e2
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>


For the series:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c b/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c
> index bf4e18f..5d70e2c 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c
> @@ -552,13 +552,13 @@ static bool atomctrl_lookup_gpio_pin(
>                                 pin_assignment->ucGpioPinBitShift;
>                         gpio_pin_assignment->us_gpio_pin_aindex =
>                                 le16_to_cpu(pin_assignment->usGpioPin_AIndex);
> -                       return false;
> +                       return true;
>                 }
>
>                 offset += offsetof(ATOM_GPIO_PIN_ASSIGNMENT, ucGPIO_ID) + 1;
>         }
>
> -       return true;
> +       return false;
>  }
>
>  /**
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list