[PATCH 2/2] drm/amdgpu: remove extra placement for AMDGPU_GEM_CREATE_NO_CPU_ACCESS

Michel Dänzer michel at daenzer.net
Mon Nov 7 02:51:50 UTC 2016


On 04/11/16 08:00 PM, Christian König wrote:
> From: Christian König <christian.koenig at amd.com>
> 
> This only has the effect of scanning the invisible range twice
> since the topdown flag is given anyway.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index 6efa8d7..052c1b0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -128,17 +128,6 @@ static void amdgpu_ttm_placement_init(struct amdgpu_device *adev,
>  		if (flags & AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS)
>  			lpfn = adev->mc.real_vram_size >> PAGE_SHIFT;
>  
> -		if (flags & AMDGPU_GEM_CREATE_NO_CPU_ACCESS &&
> -		    !(flags & AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED) &&
> -		    adev->mc.visible_vram_size < adev->mc.real_vram_size) {
> -			places[c].fpfn = visible_pfn;
> -			places[c].lpfn = lpfn;
> -			places[c].flags = TTM_PL_FLAG_WC |
> -				TTM_PL_FLAG_UNCACHED | TTM_PL_FLAG_VRAM |
> -				TTM_PL_FLAG_TOPDOWN;
> -			c++;
> -		}
> -
>  		places[c].fpfn = 0;
>  		places[c].lpfn = lpfn;
>  		places[c].flags = TTM_PL_FLAG_WC | TTM_PL_FLAG_UNCACHED |
> 

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list