[PATCH libdrm] amdgpu: add the function to get the marketing name (v3)

[Michel Dänzer]

On 08/11/16 01:02 AM, Emil Velikov wrote:
> On 7 November 2016 at 11:43, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 7 November 2016 at 09:09, Michel Dänzer <michel at daenzer.net> wrote:
>>
>>> +static struct amdgpu_asic_id_table_t {
>>> +       uint32_t did;
>>> +       uint32_t rid;
>>> +       char marketing_name[64];
>> Using a char * here might be a better. From a quick look [64] is quite wasteful.
>>
> By "quite wasteful" I meant ~doubling the binary .text size.
> Some sample numbers which I should have mentioned earlier :-\
> 
>   text    data     bss     dec     hex filename
>  10587     552       8   11147    2b8b ./a.out.fixed-size
>   5227     552       8    5787    169b ./a.out.char-star

Good catch, pushed v4 with this changed to const char *, thanks!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer