[PATCH] drm/amdgpu/powerplay: drop a redundant NULL check
Colin Ian King
colin.king at canonical.com
Tue Nov 15 16:50:08 UTC 2016
On 15/11/16 16:47, Alex Deucher wrote:
> Left over from an earlier rev of the patch.
>
> Cc: Dan Carpenter <dan.carpenter at oracle.com>
> Cc: Colin King <colin.king at canonical.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index b0c929dd..13f2b705 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -1469,8 +1469,6 @@ static int smu7_get_evv_voltages(struct pp_hwmgr *hwmgr)
> table_info->vddgfx_lookup_table, vv_id, &sclk)) {
> if (phm_cap_enabled(hwmgr->platform_descriptor.platformCaps,
> PHM_PlatformCaps_ClockStretcher)) {
> - if (table_info == NULL)
> - return -EINVAL;
> sclk_table = table_info->vdd_dep_on_sclk;
>
> for (j = 1; j < sclk_table->count; j++) {
>
Is there another instance where the table_info == NULL check can be
removed in the if (hwmgr->pp_table_version == PP_TABLE_V0) section of
the function?
Colin
More information about the amd-gfx
mailing list