[PATCH] drm/amdgpu/gfx7: move eop programming per queue

[Alex Deucher]

On Wed, Nov 23, 2016 at 6:49 PM, Alex Deucher <alexdeucher at gmail.com> wrote:
> On Wed, Nov 23, 2016 at 6:00 PM, Jay Cornwall <jay at jcornwall.me> wrote:
>> On Wed, Nov 23, 2016, at 14:27, Alex Deucher wrote:
>>> It's per queue not per pipe.
>>
>> Are you sure? I was under the impression that EOP queeus were per-pipe
>> on Gfx7 and per-queue on Gfx8 onwards (to support context save/restore).
>> It's also hinted at by the register name (HPD == Hardware Pipe
>> Descriptor, HQD == Hardware Queue Descriptor).
>
> No, I'm not sure.  I have a patch set for amdgpu to leave the
> fb_location as programmed by the vbios rather than reprogramming which
> resulted in vram not being at 0 in the GPU's address space.  I then
> got ring failures on the compute queues until I made the eops per
> queue.  It could be something else, but this seemed to fix it.

Actually I've only tried this on gfx8, I just assumed gfx7 was also
affected, but it's possible this is not needed for gfx 7.

Alex