[PATCH 4/8] drm/amdgpu: remove 128 NOP hack from vm_flush

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Wednesday, October 05, 2016 10:13 AM
> To: amd-gfx at lists.freedesktop.org
> Subject: [PATCH 4/8] drm/amdgpu: remove 128 NOP hack from vm_flush
> 
> From: Christian König <christian.koenig at amd.com>
> 
> With the padding raised to 256 DW that shouldn't be needed any more.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 8efd7db..90bb451 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -6253,10 +6253,6 @@ static void gfx_v8_0_ring_emit_vm_flush(struct
> amdgpu_ring *ring,
>  {
>  	int usepfp = (ring->type == AMDGPU_RING_TYPE_GFX);
> 
> -	/* GFX8 emits 128 dw nop to prevent DE do vm_flush before CE
> finish CEIB */
> -	if (usepfp)
> -		amdgpu_ring_insert_nop(ring, 128);
> -

Make sure to adjust the dma frame size as well in this patch.  With that fixed,
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

Alex

>  	amdgpu_ring_write(ring, PACKET3(PACKET3_WRITE_DATA, 3));
>  	amdgpu_ring_write(ring, (WRITE_DATA_ENGINE_SEL(usepfp) |
>  				 WRITE_DATA_DST_SEL(0)) |
> --
> 2.5.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx