答复: [PATCH] drm/amdgpu: avoid drm error log during S3 on RHEL7.3

[Qu, Jim]

No problem!

Thanks
JimQu

________________________________________
发件人: Christian König <deathsimple at vodafone.de>
发送时间: 2016年10月20日 15:50
收件人: Qu, Jim; amd-gfx at lists.freedesktop.org
主题: Re: [PATCH] drm/amdgpu: avoid drm error log during S3 on RHEL7.3

Am 20.10.2016 um 09:00 schrieb jimqu:
> Change-Id: I04dc3d2749d162367a6745ea0e618c4d7d3cae8d
> Signed-off-by: JimQu <Jim.Qu at amd.com>
Patch is Reviewed-by: Christian König <christian.koenig at amd.com>.

Nice catch, we probably have that on some other places as well. Have you
also checked the other DRM_ERROR() occasions in that file?

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index cf03f9f..7182812 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -530,7 +530,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>               r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,
>                                          &duplicates);
>               if (unlikely(r != 0)) {
> -                     DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
> +                     if (r != -ERESTARTSYS)
> +                             DRM_ERROR("ttm_eu_reserve_buffers failed.\n");
>                       goto error_free_pages;
>               }
>