RE: [PATCH xf86-video-ati] Sayōnara, AM_MAINTAINER_MODE!

[Deucher, Alexander]

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Michel Dänzer
> Sent: Thursday, October 20, 2016 2:38 AM
> To: amd-gfx at lists.freedesktop.org
> Subject: [PATCH xf86-video-ati] Sayōnara, AM_MAINTAINER_MODE!
> 
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> If --enable-maintainer-mode got lost from config.status for any reason,
> builds would fail in mysterious ways after changing between different
> Git commits.
> 
> There are more reasons for dropping it in the automake manual:
> 
> https://www.gnu.org/software/automake/manual/html_node/maintainer_
> 002dmode.html
> 
> I'm not aware of any reason why --disable-maintainer-mode would ever be
> useful with this project.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Glad to see it go.

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  autogen.sh   | 2 +-
>  configure.ac | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/autogen.sh b/autogen.sh
> index b47abdc..fc34bd5 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -10,5 +10,5 @@ autoreconf -v --install || exit 1
>  cd $ORIGDIR || exit $?
> 
>  if test -z "$NOCONFIGURE"; then
> -    $srcdir/configure --enable-maintainer-mode "$@"
> +    $srcdir/configure "$@"
>  fi
> diff --git a/configure.ac b/configure.ac
> index 8dc55d8..3fc967e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -36,8 +36,6 @@ AC_CONFIG_AUX_DIR(.)
>  AM_INIT_AUTOMAKE([foreign dist-bzip2])
>  AC_SYS_LARGEFILE
> 
> -AM_MAINTAINER_MODE
> -
>  # Require X.Org macros 1.8 or later for MAN_SUBSTS set by
> XORG_MANPAGE_SECTIONS
>  m4_ifndef([XORG_MACROS_VERSION],
>            [m4_fatal([must install xorg-macros 1.8 or later before running
> autoconf/autogen])])
> --
> 2.9.3
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx