[PATCH 5/6] [V2]drm/amdgpu: disable dpm before turn off clock when vce idle.

[Christian König]

Am 26.10.2016 um 12:46 schrieb Zhu, Rex:
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

It's good practice to add a short note what changed with v2 of the patch 
in the commit message, e.g. something like "v2: move return value check 
as well".

With that fixed that patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Regards,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c
> index 54a7019..8f6e7a0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/ci_dpm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/ci_dpm.c
> @@ -4258,13 +4258,12 @@ static int ci_update_vce_dpm(struct amdgpu_device *adev,
>   
>   			ret = ci_enable_vce_dpm(adev, true);
>   		} else {
> +			ret = ci_enable_vce_dpm(adev, false);
> +			if (ret)
> +				return ret;
>   			/* turn the clocks off when not encoding */
>   			ret = amdgpu_set_clockgating_state(adev, AMD_IP_BLOCK_TYPE_VCE,
>   							    AMD_CG_STATE_GATE);
> -			if (ret)
> -				return ret;
> -
> -			ret = ci_enable_vce_dpm(adev, false);
>   		}
>   	}
>   	return ret;
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20161026/00f3e8ef/attachment.html>