[PATCH 2/2] drm/radeon: handle runtime pm in fbcon (v2)

[Michel Dänzer]

On 03/09/16 02:07 PM, Edward O'Callaghan wrote:
> On 09/03/2016 01:18 AM, Alex Deucher wrote:
>> Ported from nouveau.
>>
>> v2: re-enable runtime autosuspend in the error case
>>
>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

[...]

>> @@ -47,8 +48,35 @@ struct radeon_fbdev {
>>  	struct radeon_device *rdev;
>>  };
>>  
>> +static int
>> +radeonfb_open(struct fb_info *info, int user)
>> +{
>> +	struct radeon_fbdev *rfbdev = info->par;
>> +	struct radeon_device *rdev = rfbdev->rdev;
>> +	int ret = pm_runtime_get_sync(rdev->ddev->dev);
>> +	if (ret < 0 && ret != -EACCES) {
>> +		pm_runtime_mark_last_busy(rdev->ddev->dev);
>> +		pm_runtime_put_autosuspend(rdev->ddev->dev);
>> +		return ret;
>> +	}
>> +	return 0;
> 
> Hi Alex,
> 
> Minor question - in the case of (ret == -EACCES) is that still regarded
> as successful in the context of radeonfb_open()'s call?

Yes, it is. Both patches are

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20160905/7f341d55/attachment.sig>