[PATCH] drm/amd/powerplay: fix potential issue of array access violation

Deucher, Alexander Alexander.Deucher at amd.com
Wed Sep 14 15:32:36 UTC 2016


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Wednesday, September 14, 2016 7:46 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH] drm/amd/powerplay: fix potential issue of array access
> violation
> 
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> index bfe1a14..1167205 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> @@ -399,12 +399,9 @@ int phm_reset_single_dpm_table(void *table,
> 
>  	struct vi_dpm_table *dpm_table = (struct vi_dpm_table *)table;
> 
> -	PP_ASSERT_WITH_CODE(count <= max,
> -			"Fatal error, can not set up single DPM table entries
> to exceed max number!",
> -			   );
> +	dpm_table->count = count > max ? max : count;
> 
> -	dpm_table->count = count;
> -	for (i = 0; i < max; i++)
> +	for (i = 0; i < dpm_table->count; i++)
>  		dpm_table->dpm_level[i].enabled = false;
> 
>  	return 0;
> --
> 1.9.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list