[PATCH 4/6] drm/radeon: Provide page_flip_target hook

[Mario Kleiner]

Hi Michel,

all your patches, both the already merged kernel bits in radeon/amdgpu 
and also all the userspace bits in libdrm/ati-ddx/amdgpu-ddx are all

Reviewed-and-tested-by: Mario Kleiner <mario.kleiner.de at gmail.com>

I successfully tested with old/current userspace and the new userspace 
patches from your own libdrm/ati-ddx/amdgpu-ddx repos, under radeon-kms 
with HD-5770 and amdgpu-kms with R9 380, under DRI2 and DRI3/Present 
with the new userspace and at least DRI3/Present with the old/current 
userspace (can't quite remember if i also tested with DRI2 on 
old/current userspace, but probably). Hardware measured timing tests all 
work fine.

So all is good, except for pre-DCE4 without pflip irqs, but for that see 
the patchset i just sent out, which should make those old asics work 
well as well.

-mario

On 08/16/2016 03:49 AM, Michel Dänzer wrote:
> On 16/08/16 09:35 AM, Mario Kleiner wrote:
>> Hi Michel,
>>
>> sorry for the super-late reply, i was just catching up with all the
>> mails and discussions, starting in June, leading to this patch set.
>>
>> Looks all pretty good.
>>
>> I'll look at this radeon patch and 2/6 for amdgpu later this week when i
>> have a fresh brain and enough "obsessive compulsive time", to make sure
>> all the magic wrt. "virtually extended vblank" and the fudging logic is
>> fine.
>
> Excellent!
>
>
>> I'll then also run it through my timing tests. I assume the
>> ati/amdgpu-ddx patches and libdrm patches in your freedesktop home are
>> all i need for testing?
>
> Yes, although it would also be nice to test with unmodified userspace
> and make sure there are no regressions with that.
>
>