[PATCH] drm/amdgpu: fix gtt_mgr bo's offset

zhoucm1 david1.zhou at amd.com
Tue Sep 20 10:19:33 UTC 2016



On 2016年09月20日 17:09, Flora Cui wrote:
> Change-Id: I89e9be3d5c96d46655f3a977fb557b20b4d87609
> Signed-off-by: Flora Cui <Flora.Cui at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
> index 262e872..b266cf7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
> @@ -128,8 +128,8 @@ int amdgpu_gtt_mgr_alloc(struct ttm_mem_type_manager *man,
>   
>   	if (!r) {
>   		mem->start = node->start;
> -		tbo->offset = (tbo->mem.start << PAGE_SHIFT) +
> -		    tbo->bdev->man[tbo->mem.mem_type].gpu_offset;
> +		tbo->offset = (mem->start << PAGE_SHIFT) +
> +		    tbo->bdev->man[mem->mem_type].gpu_offset;
mem->mem_type seems not set yet as well if I am correct.
IIRC, I feel it's better that tbo->offset is set out of this function 
after get_node successfully.

Regards,
David Zhou

>   	}
>   
>   	return r;



More information about the amd-gfx mailing list