mutex_destroy in amdgpu_ctx_fini()

StDenis, Tom Tom.StDenis at amd.com
Thu Sep 29 11:18:11 UTC 2016


In this block of code I'm wondering if the mutex_destroy should be hoisted out of the inner loop?

static void amdgpu_ctx_fini(struct amdgpu_ctx *ctx)
{
        struct amdgpu_device *adev = ctx->adev;
        unsigned i, j;


        if (!adev)
                return;


        for (i = 0; i < AMDGPU_MAX_RINGS; ++i)
                for (j = 0; j < amdgpu_sched_jobs; ++j) {
                        fence_put(ctx->rings[i].fences[j]);
                        mutex_destroy(&ctx->rings[i].sem_lock);
                }


Cheers,
Tom


More information about the amd-gfx mailing list