[PATCH libdrm 3/3] amdgpu: add REPLACE and CLEAR checking for VA op (v2)

Marek Olšák maraeo at gmail.com
Mon Apr 3 10:54:25 UTC 2017


On Mon, Apr 3, 2017 at 10:27 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> From: Junwei Zhang <Jerry.Zhang at amd.com>
>
> v2: fix indent
>
> Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com>
> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
> Reviewed-by: Christian König <christian.koenig at amd.com>
> ---
>  amdgpu/amdgpu_bo.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
> index f725bfd..8bc1ebd 100644
> --- a/amdgpu/amdgpu_bo.c
> +++ b/amdgpu/amdgpu_bo.c
> @@ -696,21 +696,23 @@ int amdgpu_bo_va_op_raw(amdgpu_device_handle dev,
>                         amdgpu_bo_handle bo,
>                         uint64_t offset,
>                         uint64_t size,
>                         uint64_t addr,
>                         uint64_t flags,
>                         uint32_t ops)
>  {
>         struct drm_amdgpu_gem_va va;
>         int r;
>
> -       if (ops != AMDGPU_VA_OP_MAP && ops != AMDGPU_VA_OP_UNMAP)
> +       if (ops != AMDGPU_VA_OP_MAP && ops != AMDGPU_VA_OP_UNMAP &&
> +           ops != AMDGPU_VA_OP_REPLACE && ops != AMDGPU_VA_OP_CLEAR)
> +

Spurious empty line?

Other than that, the series is:
Reviewed-by: Marek Olšák <marek.olsak at amd.com>

I don't know how Dave feels about pushing this into libdrm when it's
not in Linus's tree.

Marek


More information about the amd-gfx mailing list