[PATCH] drm/amdgpu: fix dead lock if any ip block resume failed in s3

[Michel Dänzer]

On 13/04/17 05:12 PM, Huang Rui wrote:
> Driver must free the console lock whether driver resuming successful
> or not.  Otherwise, fb_console will be always waiting for the lock and
> then cause system stuck.
> 
> [  244.405541] INFO: task kworker/0:0:4 blocked for more than 120 seconds.
> [  244.405543]       Tainted: G           OE   4.9.0-custom #1
> [  244.405544] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> [  244.405541] INFO: task kworker/0:0:4 blocked for more than 120 seconds.
> [  244.405543]       Tainted: G           OE   4.9.0-custom #1
> [  244.405544] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
> [  244.405550] kworker/0:0     D    0     4      2 0x00080000
> [  244.405559] Workqueue: events console_callback
> [  244.405564]  ffff88045a2cfc00 0000000000000000 ffff880462b75940 ffffffff81c0e500
> [  244.405568]  ffff880476419280 ffffc900018f7c90 ffffffff817dcf62 000000000000003c
> [  244.405572]  0000000100000000 0000000000000002 ffff880462b75940 ffff880462b75940
> [  244.405573] Call Trace:
> [  244.405580]  [<ffffffff817dcf62>] ? __schedule+0x222/0x6a0
> [  244.405584]  [<ffffffff817dd416>] schedule+0x36/0x80
> [  244.405588]  [<ffffffff817e041c>] schedule_timeout+0x1fc/0x390
> [  244.405592]  [<ffffffff817df1b4>] __down_common+0xa5/0xf8
> [  244.405598]  [<ffffffff810b2ca8>] ? put_prev_entity+0x48/0x710
> [  244.405601]  [<ffffffff817df224>] __down+0x1d/0x1f
> [  244.405606]  [<ffffffff810c71a1>] down+0x41/0x50
> [  244.405611]  [<ffffffff810d380a>] console_lock+0x1a/0x40
> [  244.405614]  [<ffffffff814e3c03>] console_callback+0x13/0x160
> [  244.405617]  [<ffffffff817dcf6a>] ? __schedule+0x22a/0x6a0
> [  244.405623]  [<ffffffff810954e3>] process_one_work+0x153/0x3f0
> [  244.405628]  [<ffffffff81095cab>] worker_thread+0x12b/0x4b0
> [  244.405633]  [<ffffffff81095b80>] ? rescuer_thread+0x350/0x350
> [  244.405637]  [<ffffffff8109b473>] kthread+0xd3/0xf0
> [  244.405641]  [<ffffffff8109b3a0>] ? kthread_park+0x60/0x60
> [  244.405645]  [<ffffffff8109b3a0>] ? kthread_park+0x60/0x60
> [  244.405649]  [<ffffffff817e1ee5>] ret_from_fork+0x25/0x30
> 
> Signed-off-by: Huang Rui <ray.huang at amd.com>

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer