[PATCH 09/17] drm/amdgpu: take ownership of per-pipe configuration v2

[Oded Gabbay]

With the new patch-set, I get the following error (on Kaveri), when
running KFDEventTest.SignalEvent (There are some other tests who
produce same result e.g. KFDQMTest.OverSubscribeCpQueues):

dmesg:
[  276.528643] kfd: qcm fence wait loop timeout expired
[  276.528649] kfd: the cp might be in an unrecoverable state due to
an unsuccessful queues preemption
[  276.528864] traps: kfdtest[5963] general protection ip:7f1c0dd23e5d
sp:7fffd1a419b0 error:0
[  276.528869]  in libhsakmt-1.so.0.0.1[7f1c0dd20000+8000]

Oded

On Tue, Apr 18, 2017 at 1:46 AM, Andres Rodriguez <andresx7 at gmail.com> wrote:
> Sending an updated patch with 2 bugs fixed:
>
> 1. the offset into the HPD bo was incorrect
> 2. the compute_pipe_init function had an mec/me mismatch, so registers were
> being set for the wrong ME
>
> Regards,
> Andres
>
> On 2017-04-16 01:25 AM, Oded Gabbay wrote:
>>
>> Hey Andres,
>>
>> Yes, that patch indeed fixed the black screen on Alex's 4.12-wip, but
>> it still wouldn't boot with your entire patch-set. It would boot only
>> with patches 1-8.
>>
>> I'll try to get a USB-to-serial dongle so I could try dump kernel
>> messages during boot but it will probably take some time.
>>
>> Oded
>>
>> On Sun, Apr 16, 2017 at 3:12 AM, Andres Rodriguez <andresx7 at gmail.com>
>> wrote:
>>>
>>> Hey Oded,
>>>
>>> I've had problems with 4.12-wip on its own. Just wanted to confirm if
>>> you picked up this fix for a bug in drm-next:
>>> "drm: Fix get_property logic fumble"
>>>
>>> Regards,
>>> Andres
>>>
>>> On Sat, Apr 15, 2017 at 8:37 AM, Oded Gabbay <oded.gabbay at gmail.com>
>>> wrote:
>>>>
>>>> On Fri, Apr 14, 2017 at 12:35 AM, Andres Rodriguez <andresx7 at gmail.com>
>>>> wrote:
>>>>>
>>>>> Make amdgpu the owner of all per-pipe state of the HQDs.
>>>>>
>>>>> This change will allow us to split the queues between kfd and amdgpu
>>>>> with a queue granularity instead of pipe granularity.
>>>>>
>>>>> This patch fixes kfd allocating an HDP_EOP region for its 3 pipes which
>>>>> goes unused.
>>>>>
>>>>> v2: support for gfx9
>>>>>
>>>>> Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>
>>>>> Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>
>>>>> Acked-by: Christian König <christian.koenig at amd.com>
>>>>> Signed-off-by: Andres Rodriguez <andresx7 at gmail.com>
>>>>
>>>>
>>>> Hi Andres,
>>>> FYI, with your patchset rebased on alex's drm-next-4.12-wip, my Kaveri
>>>> machine won't boot the OS (Ubuntu 16.04).
>>>> I bisected your patch-set and the first bad patch is this one.
>>>>
>>>> Unfortunately, I don't have the means to dump kernel crashes before
>>>> the system boots.
>>>>
>>>> Thx,
>>>> Oded