[PATCH] drm/amd/powerplay: add error message to remind user updating firmware

[Alex Deucher]

On Thu, Apr 20, 2017 at 3:33 AM, Huang Rui <ray.huang at amd.com> wrote:
> Signed-off-by: Huang Rui <ray.huang at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> index 2685f02..b3f3af2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c
> @@ -378,8 +378,11 @@ static int vega10_verify_smc_interface(struct pp_smumgr *smumgr)
>                         "Attempt to read SMC IF Version Number Failed!",
>                         return -1);
>
> -       if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION)
> -               return -1;
> +       if (smc_driver_if_version != SMU9_DRIVER_IF_VERSION) {
> +               pr_err("Your firmware(0x%x) doesn't match SMU9_DRIVER_IF_VERSION(0x%x). Please update your firmware!\n",
> +                      smc_driver_if_version, SMU9_DRIVER_IF_VERSION);
> +               return -EINVAL;
> +       }
>
>         return 0;
>  }
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx